This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Fix image/icon display on Growl for Windows and quote path if necessary#73
Open
MShawnDillon wants to merge 1 commit intodylang:masterfrom
MShawnDillon:master
Open
Fix image/icon display on Growl for Windows and quote path if necessary#73MShawnDillon wants to merge 1 commit intodylang:masterfrom MShawnDillon:master
MShawnDillon wants to merge 1 commit intodylang:masterfrom
MShawnDillon:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Growl for Windows was not displaying the grunt-logo.png icon and needs the *nix path separator instead of the Windows path separator to work. Additionally, if the path contained spaces it would fail with the following error since it interprets everything past the initial space (and up 'til another option, like /t) as the message:
Bad arguments : An item with the same key has already been added.
This commit fixes both issues and adds a test to ensure that, on Windows only, the spawned process is called with an appropriate image argument (*nix path separators and quoted, if the path contains spaces).
This fixes #36