This repository was archived by the owner on Jul 17, 2022. It is now read-only.
Fixed several problems running Growl for Windows#94
Open
johnmcase wants to merge 1 commit intodylang:masterfrom
Open
Fixed several problems running Growl for Windows#94johnmcase wants to merge 1 commit intodylang:masterfrom
johnmcase wants to merge 1 commit intodylang:masterfrom
Conversation
|
👍 Haven't gotten a growl since updating to node 0.12.0. Thanks @johnmcase for submitting this PR. |
Owner
|
Thanks @johnmcase! @matttrawicki, have you tried the PR to see if it fixes the problem for you? |
|
Yes, notifications are growling with these changes. |
|
I found this issue while updating to node 0.12 as well, changes also work for me. Thank you for the fix! |
johnmcase
changed the title
honsa
added a commit
to honsa/grunt-notify
that referenced
this pull request
Dec 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues on Windows. Based on Pull Request #73 with some additional updates by me.
Fixes #91 and #36
All tests pass for me on Windows 7 SP1 running node 0.12.0