Adding ability to access the GOV.UK Notify response#200
Open
Hassanmir92 wants to merge 1 commit intodxw:mainfrom
Open
Adding ability to access the GOV.UK Notify response#200Hassanmir92 wants to merge 1 commit intodxw:mainfrom
Hassanmir92 wants to merge 1 commit intodxw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mail::Notify::DeliveryMethoddefinesattr_accessor :responsebut never assigns the response returned byNotifications::Client#send_email.As a result:
delivery_method.responseis always nilSince Notify already returns a response object synchronously, this information is available but not set.
What
This PR updates the
deliver!method to assign the return value ofclient.send_emailtoself.response.This:
message.delivery_method.responseThis enables auditing, correlation, and delivery status tracking without custom overrides.