[AQTS-1308] GOV.UK Notify audit tracking with system#3091
Merged
Hassanmir92 merged 7 commits intomainfrom Mar 2, 2026
Merged
Conversation
….UK Notify API within our after_delivery callback
Hassanmir92
force-pushed
the
AQTS-1308-dev-spike-gov-uk-notify-audit-tracking-with-system
branch
from
902813c to
82b52d9
Compare
|
Review app deployed to https://apply-for-qts-review-3091-web.test.teacherservices.cloud/personas |
…l_deliveries table to capture the status of deliveries
…dit job to fetch the status of delivery from GOV.UK Notify
…the mail-notify has been released
Hassanmir92
commented
Feb 26, 2026
| # Notify returns a ResponseNotification. | ||
| # https://www.rubydoc.info/gems/notifications-ruby-client/2.2.0 | ||
| # | ||
| # TODO: We have an open PR https://github.com/dxw/mail-notify/pull/200 |
Collaborator
Author
There was a problem hiding this comment.
As mentioned in this comment. I've opened up a PR on the mail-notify repo to fix this so that we can remove this monkey-patch
Hassanmir92
changed the title
…o ensure status is updated
Hassanmir92
deleted the
AQTS-1308-dev-spike-gov-uk-notify-audit-tracking-with-system
branch
|
Review app for PR 3091 was deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://dfedigital.atlassian.net/browse/AQTS-1308
This PR ensures that with every
email_deliveryrecord we persist from ourafter_deliverycallback, we now start to track the status of these deliveries to more proactively look at application forms where communications may not have been received.Note that as part of this I've had to introduce a
mail_notify_delivery_method_with_response.rbmonkey-patch as the mail-notify gem currently doesn't provide a way for us to access the response from GOV.UK Notify once an email has been delivered to them. I would consider this patch as a temporary fix for now as I've already introduced a PR directly on the gem and hopefully if it gets approved and released we can delete this patch file.There is no UI element to this change as this is purely a backend change to start tracking the status of these deliveries while we wait for design input around how to best show this data to assessors and managers.