Skip to content

Add additional xdebug profile settings #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthony-malkoun wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

Add additional xdebug profile settings #353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions images/php/01-bay.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ disable_functions = ${BAY_DISABLE_FUNCTIONS}

[xdebug]
xdebug.mode = debug,profile
xdebug.output_dir = /app/docroot/sites/default/files/xdebug-profile
Copy link
Contributor

@GROwen GROwen Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly concerned about these ending up in the publicly available fs, could they be moved to private without affecting availability to other tools? I'm guessing not and that the output files are similar in content to a stack trace so not much of a concern but it's still a conversation I'd like to have.

Copy link
Contributor Author

@anthony-malkoun anthony-malkoun Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work if the files are in private. For local dev you can see "private" files from the host which is the requirement. I'll test and update accordingly. Thanks for the review @GROwen! Even for non local, you'd probably copy them to a local system. The main requirement is just to get them out of the container.

xdebug.use_compression = false