Add additional xdebug profile settings #353
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GROwen
reviewed
Feb 26, 2025
|
|
||
| [xdebug] | ||
| xdebug.mode = debug,profile | ||
| xdebug.output_dir = /app/docroot/sites/default/files/xdebug-profile |
Contributor
There was a problem hiding this comment.
I'm slightly concerned about these ending up in the publicly available fs, could they be moved to private without affecting availability to other tools? I'm guessing not and that the output files are similar in content to a stack trace so not much of a concern but it's still a conversation I'd like to have.
Contributor
Author
There was a problem hiding this comment.
I think this will work if the files are in private. For local dev you can see "private" files from the host which is the requirement. I'll test and update accordingly. Thanks for the review @GROwen! Even for non local, you'd probably copy them to a local system. The main requirement is just to get them out of the container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
xdebug profiling is a useful tool, but the output files by default are saved compressed and in
/tmpdirectory of each container which makes them hard to manage and view from the host machine. This change saves them uncompressed in the shared filesystem so that they are available to host tools like QCahcegrindThis change only affects settings when xdebug is enabled.
Changes
xdebugsettings to be more developer friendlyTesting
Turn on
xdebugand do some profiling using your method of choice. Files should all end up in<project_directory>/docroot/sites/default/files/xdebug-profileand be uncompressed and ready to view.