fix: Update feature with invalid planningStatus results in 500 #228#271
Conversation
ElizavetaP
left a comment
ElizavetaP
left a comment
There was a problem hiding this comment.
You fixed the bug, but you did not add test(s) to verify it. The tests are the most important part here. It is not enough to simply reference them; they must actually be present in your branch. This is also the hardest part of the task.
The proposed FAIL_TO_PASS list should be treated as guidance, and in many cases it is not possible to just copy those tests into your solution as-is. First, they come from a different branch. Second, you may need additional tests to cover edge cases. and in some situations, some checks from FAIL_TO_PASS may turn out to be unnecessary for your specific bug. The guidelines explain this in detail: bugfix guidelines.
Also, please do not forget to run ./mvnw spotless:apply, clean verify is currently failing.
FAIL_TO_PASS: FeatureControllerTests#shouldReturnBadRequestForInvalidFeaturePlanningStatus, FeatureControllerTests#shouldReturnBadRequestForBlankFeaturePlanningStatus, FeatureControllerTests#shouldReturnBadRequestForEmptyFeaturePlanningStatus
YuliaMittova
force-pushed
the
bugfix/228-update-feature-with-invalid-planningstatus-results-in-500
branch
from
9423f12 to
75a1602
Compare
3 participants
Bug fix for #228