Bugfix/228 update feature with invalid planningstatus results in 500#40
Closed
YuliaMittova wants to merge 21 commits intofeature-tracker:mainfrom
Closed
Conversation
Update workflow: maven.yml
…50726184407 Add workflow: maven.yml
…management-20250726184714 Add workflow: pr-label-management.yml
…-2-20250813081805 Add files: maven.yml,verify_java_dataset_instance.sh
fix: don't delete features when deleting a release
…74.0 Current configuration yields `NoSuchMethodError` upon compilation when using java 25, which is now fixed in `palantir-java-format:2.71.0`: palantir/palantir-java-format#1305 That only change would be sufficient, but I updated the palantir version to `2.74.0` and also the spotless plugin to `3.0.0` to comply with this change in the original repo: feature-tracker@1e2fca6 Also fixes readme that still mentioned java 21 as prerequisite, when in fact it is now java 24.
…74.0 - merge pull request #149 from dpaia/update-spotless-plugin-version
needed in tests for issue 58
### Objective
Define and implement enhanced data structures for feature planning assignments with basic API enhancements, ensuring correct database storage and immediate testability through existing endpoints.
### Requirements
**Feature Entity Enhancement:** Add planning fields to the Feature entity: `plannedCompletionAt`, `actualCompletionAt`, `featurePlanningStatus`, `featureOwner`, `blockageReason`.
**FeaturePlanningStatus Enum:** Create a new enum with values: NOT_STARTED, IN_PROGRESS, DONE, BLOCKED (separate from existing development status).
**Enhance Existing API Endpoints:**
- PUT /api/features/{code} - Update payload with planning fields
- GET /api/features/{code} - Include all planning fields in response
- GET /api/releases/{code}/features - Return features with planning fields
### Test Coverage
- Unit tests for Feature entity with new planning fields
- Integration tests for database persistence (CRUD operations)
- Integration tests for enhanced API endpoints
- Tests for database constraints and indexes
### Acceptance Criteria
- Feature entity enhanced with all planning fields and database migration completed
- FeaturePlanningStatus enum created with proper values
- Database schema includes all necessary columns and indexes
- DTOs include all planning fields
- Existing endpoints work with new planning fields
- Planning fields can be updated and retrieved
- All repository methods implemented and tested
- End-to-end integration tests verify API-to-database flow
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
your target branch should be |
FAIL_TO_PASS: FeatureControllerTests#shouldReturnBadRequestForInvalidFeaturePlanningStatus, FeatureControllerTests#shouldReturnBadRequestForBlankFeaturePlanningStatus, FeatureControllerTests#shouldReturnBadRequestForEmptyFeaturePlanningStatus
YuliaMittova
force-pushed
the
bugfix/228-update-feature-with-invalid-planningstatus-results-in-500
branch
from
9423f12 to
75a1602
Compare
Author
|
Closed because correct PR is created: dpaia#271 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for issue dpaia#228