Skip to content

Update to temporary custom built BDN version #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LoopedBard3 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Update to temporary custom built BDN version #5073

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed1db6e
Update to temporary custom built BDN version while we wait for AsmRes…
LoopedBard3 Dec 17, 2025
6dade4c
Update to use AsmResolver Dev branch.
LoopedBard3 Dec 18, 2025
f585e02
Update to use BDN before potential break.
LoopedBard3 Dec 18, 2025
56b8e18
Third times the charm.
LoopedBard3 Dec 18, 2025
80dc47e
...
LoopedBard3 Dec 18, 2025
5d256c1
.6
LoopedBard3 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<MicrosoftNETILLinkPackageVersion>10.0.0-rc.1.25555.107</MicrosoftNETILLinkPackageVersion>
<SystemThreadingChannelsPackageVersion>10.0.0-rc.1.25555.107</SystemThreadingChannelsPackageVersion>
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom BenchmarkDotNet version 0.16.0-custom lacks documentation about where this package is hosted. Consider adding a comment that explains:

  1. Where the custom package is located (e.g., which Azure Artifacts feed)
  2. Why this custom build is necessary (reference to the AsmResolver net11 support)
  3. When this can be reverted to an official release

This will help future maintainers understand the temporary nature of this change and know where to find the package.

Suggested change
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
<!--
NOTE: 0.16.0-custom is a temporary custom build of BenchmarkDotNet.
- Location: Hosted in the internal Azure Artifacts feed (e.g. dotnet-public/benchmarkdotnet).
- Reason: Includes a patched AsmResolver with net11 support required by this repo.
- Revert: Switch back to an official BenchmarkDotNet release once upstream includes AsmResolver net11 support
and this custom package is no longer necessary.
-->

Copilot uses AI. Check for mistakes.
<BenchmarkDotNetVersion>0.14.1-nightly.20250107.205</BenchmarkDotNetVersion>
<BenchmarkDotNetVersion>0.16.0-custom.6</BenchmarkDotNetVersion>
<MicrosoftNETRuntimeEmscripten3156Nodewinx64Version>10.0.0-rc.1.25555.107</MicrosoftNETRuntimeEmscripten3156Nodewinx64Version>
<MicrosoftDotNetXHarnessCLIVersion>11.0.0-prerelease.25603.1</MicrosoftDotNetXHarnessCLIVersion>
</PropertyGroup>
Expand Down
Loading