Skip to content

Conversation

@LoopedBard3
Copy link
Member

Update to temporary custom built BDN version using latest AsmResolver with net11 support while we wait for AsmResolver to officially release support for net11.0. This will fix the failing wasm runtime runs.

Performance pipeline test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2863108&view=results

…olver to officially release support for net11.0.
@LoopedBard3 LoopedBard3 self-assigned this Dec 18, 2025
@LoopedBard3 LoopedBard3 added the dependencies Pull requests that update a dependency file label Dec 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BenchmarkDotNet dependency to a temporary custom-built version (0.16.0-custom) that includes the latest AsmResolver with .NET 11.0 support. This is a workaround while waiting for an official AsmResolver release with net11 support, and is intended to fix failing WebAssembly runtime benchmark runs.

Key Changes:

  • Updated BenchmarkDotNet version from 0.14.1-nightly.20250107.205 to 0.16.0-custom

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<MicrosoftNETILLinkTasksVersion>10.0.0-rc.1.25555.107</MicrosoftNETILLinkTasksVersion>
<MicrosoftNETILLinkPackageVersion>10.0.0-rc.1.25555.107</MicrosoftNETILLinkPackageVersion>
<SystemThreadingChannelsPackageVersion>10.0.0-rc.1.25555.107</SystemThreadingChannelsPackageVersion>
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom BenchmarkDotNet version 0.16.0-custom lacks documentation about where this package is hosted. Consider adding a comment that explains:

  1. Where the custom package is located (e.g., which Azure Artifacts feed)
  2. Why this custom build is necessary (reference to the AsmResolver net11 support)
  3. When this can be reverted to an official release

This will help future maintainers understand the temporary nature of this change and know where to find the package.

Suggested change
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
<MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion>
<!--
NOTE: 0.16.0-custom is a temporary custom build of BenchmarkDotNet.
- Location: Hosted in the internal Azure Artifacts feed (e.g. dotnet-public/benchmarkdotnet).
- Reason: Includes a patched AsmResolver with net11 support required by this repo.
- Revert: Switch back to an official BenchmarkDotNet release once upstream includes AsmResolver net11 support
and this custom package is no longer necessary.
-->

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant