-
Notifications
You must be signed in to change notification settings - Fork 285
Update to temporary custom built BDN version #5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…olver to officially release support for net11.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the BenchmarkDotNet dependency to a temporary custom-built version (0.16.0-custom) that includes the latest AsmResolver with .NET 11.0 support. This is a workaround while waiting for an official AsmResolver release with net11 support, and is intended to fix failing WebAssembly runtime benchmark runs.
Key Changes:
- Updated BenchmarkDotNet version from
0.14.1-nightly.20250107.205to0.16.0-custom
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <MicrosoftNETILLinkTasksVersion>10.0.0-rc.1.25555.107</MicrosoftNETILLinkTasksVersion> | ||
| <MicrosoftNETILLinkPackageVersion>10.0.0-rc.1.25555.107</MicrosoftNETILLinkPackageVersion> | ||
| <SystemThreadingChannelsPackageVersion>10.0.0-rc.1.25555.107</SystemThreadingChannelsPackageVersion> | ||
| <MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion> |
Copilot
AI
Dec 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The custom BenchmarkDotNet version 0.16.0-custom lacks documentation about where this package is hosted. Consider adding a comment that explains:
- Where the custom package is located (e.g., which Azure Artifacts feed)
- Why this custom build is necessary (reference to the AsmResolver net11 support)
- When this can be reverted to an official release
This will help future maintainers understand the temporary nature of this change and know where to find the package.
| <MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion> | |
| <MicrosoftExtensionsLoggingPackageVersion>10.0.0-rc.1.25555.107</MicrosoftExtensionsLoggingPackageVersion> | |
| <!-- | |
| NOTE: 0.16.0-custom is a temporary custom build of BenchmarkDotNet. | |
| - Location: Hosted in the internal Azure Artifacts feed (e.g. dotnet-public/benchmarkdotnet). | |
| - Reason: Includes a patched AsmResolver with net11 support required by this repo. | |
| - Revert: Switch back to an official BenchmarkDotNet release once upstream includes AsmResolver net11 support | |
| and this custom package is no longer necessary. | |
| --> |
Update to temporary custom built BDN version using latest AsmResolver with net11 support while we wait for AsmResolver to officially release support for net11.0. This will fix the failing wasm runtime runs.
Performance pipeline test run: https://dev.azure.com/dnceng/internal/_build/results?buildId=2863108&view=results