Implement logic for creating a new incoming invoice #80

mladjo2505 · 2016-02-25T14:19:37Z

Closes #63

stoivo · 2016-03-09T19:36:43Z

Fix tabindex on invoicein.edit
Fetch period directly from fakturadato in invoicein.edit
Add new field 'unit price with tax' alongside the one we have now, unit price without tax. Unit price with tax should have higher priority than unit price without tax on invoicein.edit
Add migration for clearing 'unit price with tax' field in invoiceinline table for existing entries to 0
If we change the invoice we should update the invoice listed on invoicein.list(ex. supplier)
The amount should be calculated on save for manually created invoices
Show names for project and department on invoicein list page
Check and fix if and which JournalID the new invoice is going to get and display it correctly on the invoicein list page

mladjo2505 · 2016-03-20T10:37:28Z

modules/fakturabank/model/fakturabank.class.php

                        $datalineH['Vat']               = $line->TaxTotal->TaxSubtotal[0]->Percent;
                        #$datalineH['VatID']             = $line->Price->PriceAmount; #Denne mŒ nok mappes

+                        $datalineH['UnitCostPrice'] = $datalineH['UnitCustPrice'] + $datalineH['TaxAmount']/$Quantity;


TaxAmount is for Total for invoice line.
Add a comment to clarify this.
Check if Quantity can be 0.

stoivo · 2016-04-04T09:46:31Z

invoicein.TotalCustPrice should not be a input field since I can't save to it.
When you add a new line we get this warning: get_accountplan_object(): Mangler AccountplanID

mladjo2505 · 2016-05-20T12:40:37Z

modules/invoicein/model/invoicein.class.php

+          if(!$accountplan->City) $_lib['message']->add('Sted mangler p&aring; leverand&oslash;r kontoplan');
+          $args['invoicein_IName_' . $ID] = $accountplan->AccountName;
+          if(!$accountplan->AccountName) $_lib['message']->add('Navn mangler p&aring; leverand&oslash;r kontoplan');
+          $args['invoicein_IAddress_' . $ID] = $accountplan->Address;


Check out why this shows up on initial create for invoice

mladjo2505 · 2016-05-20T12:48:27Z

On create new invoicein page do not show 'Er med i reisegarantifondet'

mladjo2505 · 2016-05-20T13:07:27Z

On invoiceinline if we choose a car enabled accountplan and after choose another one with car disabled, clear car from that line? also globally? create a new issue?

mladjo2505 · 2016-05-20T13:18:22Z

Add an indicator in invoicein list page which invoices were imported and which were manually created.

mladjo2505 · 2016-05-20T13:30:25Z

Bilagsnumber should be shown as a link to a journal if the invoice is bookkept and empty if not, neither the imported nor the manually created invoices should have an input field which allows us to change it.

mladjo2505 · 2016-05-20T13:46:04Z

Comment out remitering stuff (both on invoice in and from menu) for now. See what to do with it later.

mladjo2505 · 2016-05-20T13:48:13Z

Add delete logic for manually created invoicein and only allow it for not yet bookkept invoices.

mladjo2505 · 2016-05-20T14:03:07Z

When we change back to an account without a car from an account with a car remove the car from the line/row.

mladjo2505 · 2016-05-30T06:09:01Z

@stoivo I see you added the "Back to rework" label to this. Other than the commented things to be done, are there any more requirements?

stoivo · 2016-05-30T06:45:13Z

@hildegunn95 will test it again when that is done.
But I don't have any other things to say.

mladjo2505 · 2016-06-02T06:09:07Z

Fixed all requests and rebased to new master.

mladjo2505 · 2016-06-06T06:22:10Z

modules/invoicein/view/edit.php

        }
        ?>
        </td>
+<? if (!$invoicein->Imported) { ?>


When exactly should this be shown and when not?
@stoivo

Now we correctly fetch the unit cost with tax and display the tax amount that we got when importing if any

Move fetching id and name for department and project to their classes Add some comments where needed Prevent devision by zero Prevent code propagation after header redirect

Fix missing address on supplier Fix missing AccountPlanID

mladjo2505 · 2017-04-27T06:05:03Z

If any more changes are to be made to this it should be squashed into one commit for convenience of rebasing.
Tested on staging lodo2016:

Creating new incoming invoice
Adding a new line
Adding an allowance/charge
Adding a line allowance/charge
Removing a line
Removing an allowance/charge
Removing a line allowance/charge

sls-lnluksa · 2017-04-27T06:27:43Z

round review -> needed 1h.

mladjo2505 · 2017-05-15T05:54:48Z

Rebase and fix (1h)

mladjo2505 self-assigned this Feb 25, 2016

stoivo added the Denied label Mar 9, 2016

mladjo2505 removed the Denied label Mar 17, 2016

mladjo2505 reviewed Mar 20, 2016
View reviewed changes

mladjo2505 added the Denied label Mar 20, 2016

mladjo2505 removed the Denied label Mar 29, 2016

mladjo2505 mentioned this pull request Apr 6, 2016

Validate invoice before locking it #115

Merged

MrdjanStojimirovic added the Testing in progress label Apr 14, 2016

mladjo2505 reviewed May 20, 2016
View reviewed changes

stoivo added the Back to rework label May 27, 2016

mladjo2505 force-pushed the md/invoicein_new branch from 1ce7dac to 54aee23 Compare June 2, 2016 06:07

mladjo2505 added 1. round review and removed Back to rework labels Jun 2, 2016

mladjo2505 reviewed Jun 6, 2016
View reviewed changes

mladjo2505 added 20 commits April 26, 2017 15:27

Fix invoicein import from fakturabank

af7fd7e

Now we correctly fetch the unit cost with tax and display the tax amount that we got when importing if any

Fix calculating invoice total amount

2386e62

Do not show the JournalID for the invoices that cannot be bookkept

e00d854

Show project and department names as well on invoicein list page

e293baa

Show who created the invoice and when if it was not imported

7d5d7d5

Update invoicein fields correctly on date/supplier change

7dbd255

Small fixes after codereview

33f5b87

Move fetching id and name for department and project to their classes Add some comments where needed Prevent devision by zero Prevent code propagation after header redirect

Fix: Just print invoicein total amount, resolve missing accountplan

737d86b

Fix after code review and discussion

35b1231

Small fixes after code review

c98dca4

Fix typos on invoicein.edit page

542c125

Fix more stuff

a93e7c0

Add invoice date validation to incoming invoice

d4c2df6

Payment means should be printed as text

ce3f06b

Fix for missing accountplan id for invoice in lines

a87998c

Recalculate invoice on save and delete

b8eed81

Fix missing address on supplier Fix missing AccountPlanID

Add warning errors to invoice incoming

49952c5

Remove more remittance stuff

070abd1

Additional fixes after code review

71bd82b

Fix invoicein show after rebase

ee52e7e

mladjo2505 force-pushed the md/invoicein_new branch 2 times, most recently from 1faaab2 to f265668 Compare April 26, 2017 13:59

Fix recalculate on save an some alignment on edit page

9bb74fe

mladjo2505 force-pushed the md/invoicein_new branch from f265668 to 9bb74fe Compare April 26, 2017 14:02

Renumber migration

4a3044d

mladjo2505 force-pushed the md/invoicein_new branch from ca59b86 to 4a3044d Compare April 27, 2017 05:54

mladjo2505 added the Back to rework label May 15, 2017

Implement logic for creating a new incoming invoice #80

Are you sure you want to change the base?

Implement logic for creating a new incoming invoice #80

Uh oh!

Conversation

mladjo2505 commented Feb 25, 2016

Uh oh!

stoivo commented Mar 9, 2016

Uh oh!

mladjo2505 Mar 20, 2016

Choose a reason for hiding this comment

Uh oh!

stoivo commented Apr 4, 2016

Uh oh!

mladjo2505 May 20, 2016

Choose a reason for hiding this comment

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 20, 2016

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mladjo2505 commented May 30, 2016

Uh oh!

stoivo commented May 30, 2016

Uh oh!

mladjo2505 commented Jun 2, 2016

Uh oh!

mladjo2505 Jun 6, 2016

Choose a reason for hiding this comment

Uh oh!

mladjo2505 commented Apr 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sls-lnluksa commented Apr 27, 2017

Uh oh!

mladjo2505 commented May 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented May 20, 2016 •

edited

Loading

mladjo2505 commented Apr 27, 2017 •

edited

Loading

mladjo2505 commented May 15, 2017 •

edited

Loading