Skip to content

Validate invoice before locking it #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stoivo merged 8 commits into from
May 23, 2016
Merged

Validate invoice before locking it #115

stoivo merged 8 commits into from
May 23, 2016

Conversation

@mladjo2505
Copy link
Contributor

@mladjo2505 mladjo2505 commented Mar 17, 2016

Closes #111

@mladjo2505 mladjo2505 self-assigned this Mar 17, 2016
@stoivo stoivo added the Denied label Mar 30, 2016
@mladjo2505 mladjo2505 removed the Denied label Apr 6, 2016
@stoivo
Copy link
Contributor

stoivo commented Apr 6, 2016

I am getting get_accountplan_object(): Mangler AccountplanID every time I save.

@mladjo2505
Copy link
Contributor Author

mladjo2505 commented Apr 6, 2016

@stoivo I will check this out, I've fixed the same thing on PR #80 for invoice incoming, where the problem was that the AccountPlanID was not passed to the get_accountplan_object() method.
I suspect the same thing is happening here just need to find where.

@stoivo stoivo added the Denied label Apr 12, 2016
@mladjo2505
Copy link
Contributor Author

mladjo2505 commented Apr 13, 2016

Can't reproduce the get_accountplan_object(): Mangler AccountplanID for invoice outgoing.
Works fine at my place, tried all I could think should reproduce it. Also in invoice.class.php i found all occurrences of that function call and they all get the correct params.

@mladjo2505 mladjo2505 removed the Denied label Apr 13, 2016
@stoivo
Copy link
Contributor

stoivo commented Apr 13, 2016

Not me either. I guess this is good then.

@stoivo stoivo added the QA label Apr 13, 2016
@stoivo
Copy link
Contributor

stoivo commented Apr 13, 2016

We should validate Fakturadato and Forfallsdato for 0000-00-00
We should validate all fields under Leveringsadresse (Adresse, Postnummer, Poststed, Land)
Also we want to to show the validation messages under the lock button all the time (still keep the old one). If there are any invalid stuff the lock and fakturabank buttons should be disabled.

@stoivo stoivo added Denied and removed QA labels Apr 13, 2016
@stoivo
Copy link
Contributor

stoivo commented Apr 19, 2016

The warning messages on top of page are printed twice. This didn't happen before.

stoivo
stoivo reviewed Apr 19, 2016
View reviewed changes
modules/invoice/view/record.inc Outdated
}

if($_lib['input']->getProperty('action_invoice_lock')) {
$invoice->init(array());
Copy link
Contributor

@stoivo stoivo Apr 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this since we call init on line 119.

@mladjo2505
Copy link
Contributor Author

mladjo2505 commented Apr 25, 2016

@stoivo The error duplication does not happen on my machine, you have to show me what happens.

@mladjo2505
Copy link
Contributor Author

mladjo2505 commented May 18, 2016

CustomerAccountPlanID is not loaded on first load of invoice edit page and so are the City, ZipCode and Name fields. Fix this.

@mladjo2505
Copy link
Contributor Author

mladjo2505 commented May 18, 2016

Fixed.

@stoivo stoivo merged commit 0d9d9c7 into master May 23, 2016
@stoivo stoivo added Deployed and removed QA labels May 23, 2016
@stoivo stoivo deleted the md/validate_invoice_on_lock branch July 5, 2016 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mladjo2505 mladjo2505

Labels

Deployed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mladjo2505 @stoivo