Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jan 24, 2018

still needs docker/golang-cross#3 to be merged, and a new version built on Docker Hub so that we can update the Dockerfile.cross

release notes: https://golang.org/doc/devel/release.html#go1.9.minor

full diff: golang/go@go1.9.2...go1.9.3

ping @vdemeester @dnephin

@dnephin
Copy link
Contributor

dnephin commented Jan 24, 2018

@codecov-io
Copy link

codecov-io commented Jan 24, 2018

Codecov Report

Merging #827 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #827   +/-   ##
=======================================
  Coverage   52.96%   52.96%           
=======================================
  Files         244      244           
  Lines       15828    15828           
=======================================
  Hits         8383     8383           
  Misses       6891     6891           
  Partials      554      554

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐻

@thaJeztah
Copy link
Member Author

don't merge yet, I have to update https://hub.docker.com/r/dockercore/golang-cross/tags/ as well

@dnephin
Copy link
Contributor

dnephin commented Jan 24, 2018

Just tagged dockercore/golang-cross:1.9.3

2ac6046dd738cf83a7557a9fc2be52accb97c103c5e9d2c2a50daa797c8eb79f

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Thanks! Updated 👍

@dnephin dnephin merged commit 819df0e into docker:master Jan 24, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.02.0 milestone Jan 24, 2018
@dnephin
Copy link
Contributor

dnephin commented Jan 24, 2018

Thanks!

@thaJeztah thaJeztah deleted the bump-go-1.9.3 branch January 24, 2018 23:51
@thaJeztah thaJeztah modified the milestones: 18.02.0, 18.03.0 Jan 31, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Bump Go to 1.9.3
Upstream-commit: 819df0e
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants