Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@thaJeztah
Copy link
Member

cherry-pick of docker/cli#827 for 18.02

git checkout -b 18.02-backport-bump-golang-1.9.3 upstream/18.02
git cherry-pick -s -S -x -Xsubtree=components/cli ffc76483226ee1528cab5cf8ea78c0824272cd58

no conflicts

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit ffc76483226ee1528cab5cf8ea78c0824272cd58)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.02.0 milestone Jan 26, 2018
Copy link
Contributor

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Contributor

Looks like failure on s390x and ppc64le on just 1 test:

panic: DockerSuite.TestAttachAfterDetach test timed out after 5m0s [recovered]
	panic: DockerSuite.TestAttachAfterDetach test timed out after 5m0s

Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With merge of #406 to 18.02 branch, tests are now green.

@andrewhsu andrewhsu merged commit 30849d8 into docker-archive:18.02 Jan 31, 2018
@thaJeztah thaJeztah deleted the 18.02-backport-bump-golang-1.9.3 branch January 31, 2018 23:32
docker-jenkins pushed a commit that referenced this pull request Oct 21, 2019
[master] deb: make "rules" executable
Upstream-commit: b49f9d4
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Oct 28, 2019
[18.09 backport] assorted test-fixes
Upstream-commit: 2c9fee21596c376a224646ddf86e2437fd10b560
Component: engine
silvin-lubecki pushed a commit to silvin-lubecki/docker-ce that referenced this pull request Jan 24, 2020
…ump-golang-1.9.3

[18.02] Bump Go to 1.9.3
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
[master] deb: make "rules" executable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants