Skip to content

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Jan 22, 2018

An older PR had changes which didn't work with master. This var was moved to fixtures

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov-io
Copy link

codecov-io commented Jan 22, 2018

Codecov Report

Merging #826 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   52.96%   52.95%   -0.01%     
==========================================
  Files         244      244              
  Lines       15828    15828              
==========================================
- Hits         8383     8382       -1     
- Misses       6891     6892       +1     
  Partials      554      554

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit f252944 into docker:master Jan 22, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.02.0 milestone Jan 22, 2018
@dnephin dnephin deleted the fix-lint-errors branch January 22, 2018 23:19
@dnephin dnephin mentioned this pull request Jan 24, 2018
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
Fix lint on master
Upstream-commit: f252944
Component: cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants