restore support for env variables to configure proxy #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regression introduced by b34f34 close #39654 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
silvin-lubecki
approved these changes
Aug 22, 2019
Contributor
silvin-lubecki
left a comment
silvin-lubecki
left a comment
There was a problem hiding this comment.
LGTM, thank you @ndeloof !! 👍
Codecov Report
@@ Coverage Diff @@
## master #2059 +/- ##
=======================================
Coverage 56.78% 56.78%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12400 12400
Misses 8520 8520
Partials 916 916 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2059 +/- ##
=======================================
Coverage 56.78% 56.78%
=======================================
Files 311 311
Lines 21836 21836
=======================================
Hits 12400 12400
Misses 8520 8520
Partials 916 916 |
thaJeztah
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
thaJeztah
approved these changes
Aug 22, 2019
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
nice find; easy to miss!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression introduced by b34f340 (#1501)
fixes #2027
fixes moby/moby#39654
Signed-off-by: Nicolas De Loof nicolas.deloof@gmail.com
- What I did
fix moby/moby#39654
- How I did it
restored order of client.Opt. WithHttpClient must come first
- How to verify it
added a test case to cover this scenario
- Description for the changelog
restore support for env variables to configure proxy
- A picture of a cute animal (not mandatory but encouraged)
