[19.03 backport] restore support for env variables to configure proxy #2061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regression introduced by b34f34 close #39654 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> (cherry picked from commit e25e077) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @silvin-lubecki @ndeloof PTAL |
Codecov Report
@@ Coverage Diff @@
## 19.03 #2061 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 311 311
Lines 21824 21824
=======================================
Hits 12387 12387
Misses 8522 8522
Partials 915 915 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 19.03 #2061 +/- ##
=======================================
Coverage 56.75% 56.75%
=======================================
Files 311 311
Lines 21824 21824
=======================================
Hits 12387 12387
Misses 8522 8522
Partials 915 915 |
Member
Author
|
all green; merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ENGCORE-930
backport of #2059
regression introduced by b34f340 (#1501)
fixes #2027
fixes moby/moby#39654
Signed-off-by: Nicolas De Loof nicolas.deloof@gmail.com
- What I did
fix moby/moby#39654
- How I did it
restored order of client.Opt. WithHttpClient must come first
- How to verify it
added a test case to cover this scenario
- Description for the changelog
restore support for env variables to configure proxy
- A picture of a cute animal (not mandatory but encouraged)
