Skip to content

Conversation

@ScottBrenner
Copy link
Contributor

@ScottBrenner ScottBrenner commented Oct 10, 2018

- What I did
Typo fix for docker run's --volume documentation.

- Description for the changelog
Typo fix for docker run's --volume documentation.

- A picture of a cute animal (not mandatory but encouraged)
🐇

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:ScottBrenner/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Quick syntax fix!

Signed-off-by: Scott Brenner <scott@scottbrenner.me>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io
Copy link

Codecov Report

Merging #1434 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files         289      289           
  Lines       19359    19359           
=======================================
  Hits        10498    10498           
  Misses       8185     8185           
  Partials      676      676

@thaJeztah thaJeztah merged commit 891fa63 into docker:master Oct 10, 2018
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Oct 10, 2018
@ScottBrenner ScottBrenner deleted the patch-1 branch October 10, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants