[18.09 backport] various docs fixes #1483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anda Xu <anda.xu@docker.com> (cherry picked from commit d656706) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Rui Cao <ruicao@alauda.io> (cherry picked from commit 2eb9590) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Alex Mayer <amayer5125@gmail.com> (cherry picked from commit 2b0fdd0) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ddadd3d mass standardized the formatting, with some errors. This commit fixes errors on `login.md`: - revert wrong `Logging out` headline - restore correct level for some headlines (relative to parent headline level change) - re-add `Usage` headlines, with better name Also add `related commands` headline on `login` and `logout`. Signed-off-by: Thomas Riccardi <thomas@deepomatic.com> (cherry picked from commit a0e3ec8) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
I am attempting to push a tag to a private repository. The documentation for `docker tag` has an explicit example to for how ["To push an image to a private registry"](https://docs.docker.com/engine/reference/commandline/tag/#tag-an-image-referenced-by-name). My colleague clarified that this command does not in fact push anything, so I thought this PR might save some future novice the same confusion. Signed-off-by: Jake Lambert <jake.lambert@volusion.com> (cherry picked from commit 4ed484b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Quick syntax fix! Signed-off-by: Scott Brenner <scott@scottbrenner.me> (cherry picked from commit 50143cf) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Brandon Mitchell <git@bmitch.net> (cherry picked from commit f913b73) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Brandon Mitchell <git@bmitch.net> (cherry picked from commit 3f4f450) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The issue with password auth is tracked in docker#1476 and docker#1477 . Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp> (cherry picked from commit 16b014e) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Member
Author
|
ha! you were fast |
Codecov Report
@@ Coverage Diff @@
## 18.09 #1483 +/- ##
=======================================
Coverage 54.07% 54.07%
=======================================
Files 290 290
Lines 19394 19394
=======================================
Hits 10488 10488
Misses 8235 8235
Partials 671 671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the following documentation fixes for 18.09:
cherry-picks were clean; no conflicts