Fix docker invalid-subcommand regression
#1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with a3fe7d6, `docker invalid-subcommand` did not exit with non-zero status. Fix docker#1428 Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 54.22% 54.23% +<.01%
==========================================
Files 289 289
Lines 19359 19362 +3
==========================================
+ Hits 10498 10501 +3
+ Misses 8185 8183 -2
- Partials 676 678 +2 |
Member
|
@AkihiroSuda wondering if we should have a fix for this upstream in cobra |
Member
|
Oh, actually, I see it's on our side |
Collaborator
Author
|
@thaJeztah @cpuguy83 PTAL? |
thaJeztah
approved these changes
Oct 24, 2018
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
whoops, thought I LGTM'd already 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
- What I did
Starting with a3fe7d6 (#1069),
docker invalid-subcommanddid not exit with non-zero status.Fix #1428
- How I did it
Restored
RunE- How to verify it
- Description for the changelog
Fix
docker invalid-subcommandregression- A picture of a cute animal (not mandatory but encouraged)
🐧