Skip to content

Conversation

@thaJeztah
Copy link
Member

backport of #1429 for 18.09

git checkout -b 18.09_backport_fix_docker_invalid_subcommand upstream/18.09
git cherry-pick -s -S -x d708cada43f31b79462e6d7325fbcfd75b47ae29

cherry-pick was clean; no conflicts

Starting with a3fe7d6,
docker invalid-subcommand did not exit with non-zero status.

Fix #1428

Starting with a3fe7d6,
`docker invalid-subcommand` did not exit with non-zero status.

Fix docker#1428

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
(cherry picked from commit d708cad)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.0 milestone Oct 24, 2018
@thaJeztah
Copy link
Member Author

ping @AkihiroSuda @vdemeester @cpuguy83

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester vdemeester merged commit b8911a3 into docker:18.09 Oct 25, 2018
@thaJeztah thaJeztah deleted the 18.09_backport_fix_docker_invalid_subcommand branch October 25, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants