Feature/update to go 1.17 #223
Conversation
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Thanks! I think these updates looks good. I'll take another look once all the other PRs are merged and this is rebased to reduce the diff.
This reverts commit b7dcbd2.
aidan-mundy
force-pushed
the
feature/update-to-go-1.17
branch
from
5c71ae6 to
79863c9
Compare
|
Should be all set @dnephin. Forgot to mention in the OP that this MR was built and tested using itself, I haven't tested building it with an older version of Dobi, but it should be fine. |
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Thanks for upgarding all of these things! Just one request for changing moby/moby back to docker/docker to remove the duplicate sources.
| github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 | ||
| github.com/lithammer/dedent v1.1.0 | ||
| github.com/metakeule/fmtdate v1.1.2 | ||
| github.com/moby/moby v20.10.9+incompatible |
There was a problem hiding this comment.
I'm not sure about using moby/moby here. Does docker/docker not work? All the imports at moby/moby are still docker: ex: https://github.com/moby/moby/blob/master/image/image.go#L1
And we have github.com/docker/docker v20.10.9+incompatible below, which makes me think this is not being included twice. I think we should import docker/docker and use it as the module as well.
2 participants
Updates a lot of dependencies and dockerfiles in the project to use the (near) latest versions.
Includes the changes from #219 #220 #221 #222 because some of them were required for proper operation, and I didn't feel like messing around with the git history. I can separate them out if requested. I would suggest reviewing and merging those PRs before this one.