Cleanup/refactor actions #228
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
October 23, 2021 18:05
This reverts commit b7dcbd2.
Contributor
Author
|
A future optimization to these changes would be to frontload action parsing during the config reading process and store Name items instead of raw strings, instead of passing errors all over the place if dependency parsing fails later. |
aidan-mundy
force-pushed
the
cleanup/refactor-actions
branch
from
9c2b470 to
0cf5bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #223 (includes commits from that PR)
Depends on #226 (includes commits from that PR)
Relates to #227
This is a large refactor of how actions/dependencies are handled.
It resolves item 2 in #227, and as far as I can tell it also resolves item 1 in #227 (prior to these updates, dependencies would sometimes be built before deleting the "depended")
NOTE: Marked as draft for now because resolving items 1&2 causes item 3 to be much more noticeable.