Skip to content

update sp800_22_non_overlapping_template_matching_test.py #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
goonstream wants to merge 2 commits into
base: master
Choose a base branch
from
Open

update sp800_22_non_overlapping_template_matching_test.py #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e9eea5
update sp800_22_non_overlapping_template_matching_test.py
Mar 28, 2025
2b2f557
Update sp800_22_non_overlapping_template_matching_test.py
goonstream Mar 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sp800_22_non_overlapping_template_matching_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ def non_overlapping_template_matching_test(bits):
W.append(count)

mu = float(M-m+1)/float(2**m) # Compute mu and sigma
sigma = M * ((1.0/float(2**m))-(float((2*m)-1)/float(2**(2*m))))
variance = M * ((1.0/float(2**m))-(float((2*m)-1)/float(2**(2*m))))
Copy link
Author

@goonstream goonstream Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation, the original sigma was actually variance


chisq = 0.0 # Compute Chi-Square
for j in range(N):
chisq += ((W[j] - mu)**2)/(sigma**2)
chisq += ((W[j] - mu)**2)/(variance)

p = gammaincc(N/2.0, chisq/2.0) # Compute P value
Copy link
Author

@goonstream goonstream Mar 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to change here, the original author code is inherently correct


Expand Down