update sp800_22_non_overlapping_template_matching_test.py#24
Open
goonstream wants to merge 2 commits intodj-on-github:masterfrom
Open
update sp800_22_non_overlapping_template_matching_test.py#24goonstream wants to merge 2 commits intodj-on-github:masterfrom
goonstream wants to merge 2 commits intodj-on-github:masterfrom
Conversation
goonstream
commented
Mar 30, 2025
|
|
||
| mu = float(M-m+1)/float(2**m) # Compute mu and sigma | ||
| sigma = M * ((1.0/float(2**m))-(float((2*m)-1)/float(2**(2*m)))) | ||
| variance = M * ((1.0/float(2**m))-(float((2*m)-1)/float(2**(2*m)))) |
Author
There was a problem hiding this comment.
According to the documentation, the original sigma was actually variance
goonstream
commented
Mar 30, 2025
| chisq += ((W[j] - mu)**2)/(variance) | ||
|
|
||
| p = gammaincc((N-1)/2.0, chisq/2.0) # Compute P value | ||
| p = gammaincc(N/2.0, chisq/2.0) # Compute P value |
Author
There was a problem hiding this comment.
There is no need to change here, the original author code is inherently correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the sp800_22_non_overlapping_template_matching_test.py, I observed that the calculated p-value occasionally exceeded 1. After investigation, this anomaly was traced to an implementation error in the chi-square statistic calculation within the code