Check that system status is marked Good after update in release-validation tests #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "naive" check fails currently, because /boot/status.ini gets corrupted due an (unclean) system_reset "soon" after an install (which is the equivalent of a power plug). The existing statusfile-recovery does not seem to be sufficient. It might be due to this being run in a VM and/or due to using a virtual file-backed disk, but illustrates a problem with using a FAT filesystem for persisting RAUC's status file. Unfortunately, there is no way to trigger a "clean" reboot and no easy way to fix this for existing systems and their DISK images, so instead we work-around the issue by giving time for an unmount/fsync to happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted from #293, decoupling the RAUC status file fixes from the actual checking that status is marked as Good post reboot.
A "naive" check fails currently, because /boot/status.ini gets corrupted due an (unclean) system_reset "soon" after an install (which is the equivalent of a power plug). The existing statusfile-recovery does not seem to be sufficient. It might be due to this being run in a VM and/or due to using a virtual file-backed disk, but illustrates a problem with using a FAT filesystem for persisting RAUC's status file.
Unfortunately, there is no way to trigger a "clean" reboot and no easy way to fix this for existing systems and their DISK images, so instead we work-around the issue by giving time for an unmount/fsync to happen.