PoC: Move RAUC statusfile to persistent storage and check Status in release-validation post update #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stems QEMU's system_reset does an "unclean" reboot (power plug), which causes corruption of the FAT filesystem in the test. There is no way to fix this for existing systems and their DISK images, so instead we try to work-around the issue by giving time for an unmount/fsync to happen.
Currently this check fails because /boot/status.ini gets corrupted after the upgrade due to an unclean system reset in the tests (and maybe due to running in a VM).
Member
knuton
added
details needed
Collaborator
Author
|
Let's keep this around for/when we consider the skeleton matrix and etc? If anything, it's a useful illustrative example of what kind of problematic interactions might happen between the running system and the skeleton. I think it's also worth considering how to deal with this issue, the approach used here could be used as a safer alternative to only having the statusfile in /boot / FAT, provides extra disaster recovery. As discussed, it could also be a different approach (e.g. recreate status file from scratch), but some approach is needed. |
knuton
removed
the
details needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out with b9143cc - after the select-display bug, I wanted to extend the tests to check that post-update the system reaches a Good state. When I tried that, I realized that does NOT happen in release-validation tests, since
/boot/status.inigets corrupted and statusfile-recovery fails. This is due FAT shenanigans to the uncleansystem_resetused in the test. See attached screenshots.So this is actually 2 PRs, but I wanted to illustrate that the moving of RAUC to persistent storage kinda works already in the tests.
The actual implementation can be simplified and needs more tests/clean-up, but opening this draft so we can discuss it.
/boot/status.ini corruption in release-valdiation tests without 2414fd3