Skip to content

Upgrade GitHub Actions for Node 24 compatibility #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salmanmkc wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Upgrade GitHub Actions for Node 24 compatibility #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/docker-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ runs:
sudo rm -rf /usr/local/lib/android
echo -e "post cleanup space:\n $(df -h)"

- uses: actions/checkout@v4
- uses: actions/checkout@v6

- uses: docker/login-action@v3
Copy link
Contributor

@greptile-apps greptile-apps bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker actions still on Node 20

Several Docker actions in this file (and across the other workflow files) are still running on Node 20 and have newer Node 24-compatible versions available:

  • docker/login-action@v3 → v4 is available with Node 24 support
  • docker/setup-buildx-action@v3 → v4 is available with Node 24 support
  • docker/build-push-action@v6 → v7 is available with Node 24 support

Since the goal of this PR is Node 24 compatibility, these should also be upgraded to fully resolve the deprecation warnings. The same pattern applies in:

  • .github/workflows/_docker-build-template.yml (lines 119, 127, 131, 138)
  • .github/workflows/docker.yml (lines 166, 172, 174, 180)

with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/_docker-build-template.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: |
sudo chown -R $USER:$USER ${{ github.workspace }} || true

- uses: actions/checkout@v4
- uses: actions/checkout@v6
if: ${{ inputs.should-run }}
with:
fetch-depth: 0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code-cleanup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
run: |
sudo chown -R $USER:$USER ${{ github.workspace }} || true

- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- uses: actions/checkout@v6
- uses: actions/setup-python@v6
- uses: astral-sh/setup-uv@v4
- name: Run pre-commit
id: pre-commit-first
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
run: |
sudo chown -R $USER:$USER ${{ github.workspace }} || true

- uses: actions/checkout@v4
- uses: actions/checkout@v6
- id: filter
uses: dorny/paths-filter@v3
with:
Expand Down Expand Up @@ -149,12 +149,12 @@ jobs:
run: |
sudo chown -R $USER:$USER ${{ github.workspace }} || true

- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Checkout ros-navigation-autonomy-stack
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
repository: dimensionalOS/ros-navigation-autonomy-stack
ref: fastlio2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
ALIBABA_API_KEY: ${{ secrets.ALIBABA_API_KEY }}

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6

- name: Fix permissions
run: |
Expand All @@ -49,7 +49,7 @@ jobs:

- name: Upload coverage report
if: inputs.upload-coverage && !cancelled()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: coverage-report
path: htmlcov/
Expand Down