Upgrade GitHub Actions for Node 24 compatibility#1566
Open
salmanmkc wants to merge 1 commit intodimensionalOS:mainfrom
Open
Upgrade GitHub Actions for Node 24 compatibility#1566salmanmkc wants to merge 1 commit intodimensionalOS:mainfrom
salmanmkc wants to merge 1 commit intodimensionalOS:mainfrom
Conversation
Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
Contributor
Greptile SummaryThis PR upgrades the official GitHub Actions (
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph Upgraded["Upgraded to Node 24 ✅"]
A["actions/checkout@v6"]
B["actions/setup-python@v6"]
C["actions/upload-artifact@v7"]
end
subgraph NotUpgraded["Still on Node 20 ⚠️"]
D["docker/login-action@v3"]
E["docker/setup-buildx-action@v3"]
F["docker/build-push-action@v6"]
G["crazy-max/ghaction-github-runtime@v3"]
end
subgraph Workflows
W1["code-cleanup.yml"]
W2["tests.yml"]
W3["docker.yml"]
W4["_docker-build-template.yml"]
W5["action.yml"]
end
W1 --> A & B
W2 --> A & C
W3 --> A & D & E & F & G
W4 --> A & D & E & F & G
W5 --> A & D & E & F & G
Last reviewed commit: 59f7295 |
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@v6 | ||
|
|
||
| - uses: docker/login-action@v3 |
Contributor
There was a problem hiding this comment.
Docker actions still on Node 20
Several Docker actions in this file (and across the other workflow files) are still running on Node 20 and have newer Node 24-compatible versions available:
docker/login-action@v3→ v4 is available with Node 24 supportdocker/setup-buildx-action@v3→ v4 is available with Node 24 supportdocker/build-push-action@v6→ v7 is available with Node 24 support
Since the goal of this PR is Node 24 compatibility, these should also be upgraded to fully resolve the deprecation warnings. The same pattern applies in:
.github/workflows/_docker-build-template.yml(lines 119, 127, 131, 138).github/workflows/docker.yml(lines 166, 172, 174, 180)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
You may currently be seeing a warning like this in your workflow runs:
The exact actions listed will vary per workflow.
Upgrades GitHub Actions to versions that support Node 24, since Node 20 is reaching EOL in April 2026.
Changes
actions/checkoutv3,v4v6actions/setup-pythonv3v6actions/upload-artifactv4v7Context
Per GitHub's announcement, Node 20 is being deprecated and runners will default to Node 24 starting June 2nd, 2026.
Notes
Worth running the workflows on a branch before merging to make sure everything still works.