fix(cketh): use try_send instead of send for calls to the EVM RPC canister#8821
Open
gregorydemay wants to merge 4 commits intomasterfrom
Open
fix(cketh): use try_send instead of send for calls to the EVM RPC canister#8821gregorydemay wants to merge 4 commits intomasterfrom
try_send instead of send for calls to the EVM RPC canister#8821gregorydemay wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To call the EVM RPC canister, the ckETH/ckERC20 minter uses the
EvmRpcClient::sendmethod, which panics in case the call to the EVM RPC canister could not be made, e.g. the EVM RPC canister is stopped due to an upgrade. This PR fixes this by using instead thetry_sendmethod and dealing with the client errorIcErroras follows:ConsistentErrorenum to distinguish between IC client errors (IcError) and EVM RPC canister errors (RpcError).sendmethos.