feat(ic-canister-runtime): Prevent calls when stopping#78
Open
gregorydemay wants to merge 1 commit intomainfrom
Open
feat(ic-canister-runtime): Prevent calls when stopping#78gregorydemay wants to merge 1 commit intomainfrom
gregorydemay wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #76 to ensure that by default the
IcRuntimeused in production does not make inter-canister calls when the canister is in theStoppingstate to ensure that it can be stopped promptly. While adding this feature to this crate is easy, deploying it to ensure its correctness takes a few PRs:ic-canister-runtimelibrary in the EVM RPC client, see chore: update ic-canister-runtime evm-rpc-canister#555try_sendinstead ofsendfor calls to the EVM RPC canister ic#8821