fix: add knip config, pre-commit hook, fix Zod compatibility, and remove unused code #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ichoosetoaccept
force-pushed
the
12-30-chore_add_knip_config_pre-commit_hook_fix_zod_compatibility_and_remove_unused_code
branch
from
82f240a to
f1d7d76
Compare
ichoosetoaccept
changed the title
Member
Author
Merge activity
|
ichoosetoaccept
changed the base branch from
12-30-chore_remove_broken_oauth-tests.ts_and_fix_remote-auth-tests.ts
to
graphite-base/38
ichoosetoaccept
force-pushed
the
12-30-chore_add_knip_config_pre-commit_hook_fix_zod_compatibility_and_remove_unused_code
branch
from
f1d7d76 to
5ceab6e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
## [0.3.1](v0.3.0...v0.3.1) (2025-12-30) ### Bug Fixes * add knip config, pre-commit hook, fix Zod compatibility, and remove unused code ([#38](#38)) ([a34d956](a34d956))
|
🎉 This PR is included in version 0.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds knip configuration for dead code detection, adds knip as a pre-commit hook, fixes Zod v3/v4 compatibility, and removes all unused code identified by knip.
Changes
Added
knip.json- Configuration for knip dead code detector with proper entry pointFixed
import { ZodType } from 'zod'with a permissive type alias to support both Zod versionsRemoved (unused code)
src/utils/index.ts- Unused barrel filegetRegistry(),resetRegistry()- Unused singleton pattern in tool-registrygetLogger(),setLogger()- Unused singleton pattern in loggerGitLabClientConfiginterface - Never usedRegistryAdapterexport - Made private (only used internally)src/registry/index.tsVerification
bunx knipreports no issues ✅bun run check(biome) passes ✅