Skip to content

Conversation

@ichoosetoaccept
Copy link
Member

@ichoosetoaccept ichoosetoaccept commented Dec 30, 2025

Summary

Cleans up broken upstream test files:

Changes

Removed: test/oauth-tests.ts

  • Imported GitLabOAuth from ../oauth.js which doesn't exist in this fork
  • OAuth functionality was never ported from upstream

Fixed: test/remote-auth-tests.ts

  • Removed node-fetch import (package was removed in previous PR)
  • Now uses native fetch (available in Bun and Node 18+)
  • Verified file runs correctly (just needs GitLab credentials)

Updated: test/README.md

  • Removed all OAuth-related documentation
  • Cleaned up references to deleted test file

Verification

  • Build passes ✅
  • All 122 unit tests pass ✅
  • remote-auth-tests.ts runs with bun (requires GitLab token)

Copy link
Member Author

ichoosetoaccept commented Dec 30, 2025

Copy link
Member Author

ichoosetoaccept commented Dec 30, 2025

Merge activity

  • Dec 30, 10:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 30, 10:01 AM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 30, 10:02 AM UTC: @ichoosetoaccept merged this pull request with Graphite.

@ichoosetoaccept ichoosetoaccept changed the base branch from 12-30-chore_remove_11_unused_upstream_dependencies to graphite-base/37 December 30, 2025 10:00
@ichoosetoaccept ichoosetoaccept changed the base branch from graphite-base/37 to main December 30, 2025 10:00
@ichoosetoaccept ichoosetoaccept force-pushed the 12-30-chore_remove_broken_oauth-tests.ts_and_fix_remote-auth-tests.ts branch from 44c8477 to 8a1a80a Compare December 30, 2025 10:01
@ichoosetoaccept ichoosetoaccept merged commit d3d1ade into main Dec 30, 2025
3 checks passed
@github-actions
Copy link

🎉 This PR is included in version 0.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants