Refactor: Centralize factory logic and deduplicate utilities #120
Conversation
- Extract generic utilities (generateUniqueId, vector3ToTuple) to src/lib/utils.ts - Move factory placement logic to src/ecs/factories/placement.ts - Centralize factory upgrade cost configuration in src/ecs/factories/config.ts - Refactor src/state/utils.ts to re-export from new locations, removing duplicated implementation - Update src/state/constants.ts to use shared upgrade configuration - Update imports in consumers (factorySlice, ToastProvider)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- bump zustand from 5.0.9 to 5.0.10 - update @types/node from 25.0.3 to 25.0.9 - update @types/react from 19.2.7 to 19.2.8 - bump @typescript-eslint/eslint-plugin and parser from 8.52.0 to 8.53.0 - update @vitest/coverage-v8 from 4.0.16 to 4.0.17 - upgrade postcss-nesting from 13.0.2 to 14.0.0 - update postcss-preset-env from 10.6.0 to 11.1.1 - bump prettier from 3.7.4 to 3.8.0 - update vite from rolldown-vite@7.3.0 to rolldown-vite@7.3.1 - bump vitest from 4.0.16 to 4.0.17
deadronos
deleted the
refactor-factory-logic-clustering-1761530404747206814
branch
1 participant
This PR addresses code duplication and logic scattering by:
src/state/utils.tstosrc/lib/utils.tsandsrc/lib/rng.ts.src/ecs/factories/placement.ts.src/ecs/factories/config.ts(FACTORY_UPGRADE_CONFIG) and updatingsrc/state/constants.tsto use this single source of truth.src/state/utils.tsto act as a backward-compatible facade that re-exports the moved functions.This ensures that the ECS engine and the State store share the exact same logic for upgrade costs and placement, preventing divergence and reducing maintenance burden.
PR created automatically by Jules for task 1761530404747206814 started by @deadronos