acc: Volumes references to catalog are not resolved as depends_on if used var.catalog syntax#4846
Merged
andrewnester merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
Eligible reviewersCould not determine reviewers from git history. Based on CODEOWNERS, these people or teams could review: @anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum Suggestions based on git history of 5 changed files (0 scored). See CODEOWNERS for path-specific ownership rules. |
denik
approved these changes
Mar 26, 2026
Collaborator
|
Commit: ed49fa8
23 interesting tests: 10 SKIP, 7 flaky, 6 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 45710fc
42 interesting tests: 21 RECOVERED, 10 FAIL, 6 flaky, 3 KNOWN, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added a test to confirm columes references to catalog are not resolved as depends_on if used
${var.catalog}syntaxWhy
This is unexpected that
${var.catalog}does not work but${resouces.catalogs.catalog...}doesTests
Added an acceptance test