Skip to content

[PLUGIN-1845] Return null for ErrorDetailsProvider by default #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psainics merged 1 commit into from
Jan 23, 2025
Merged

[PLUGIN-1845] Return null for ErrorDetailsProvider by default #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions database-commons/src/main/java/io/cdap/plugin/db/sink/AbstractDBSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public void validateOperations(FailureCollector collector, T dbSinkConfig, @Null
* @return ErrorDetailsProvider class name
*/
protected String getErrorDetailsProviderClassName() {
return DBErrorDetailsProvider.class.getName();
return null;
}

@Override
Expand Down Expand Up @@ -240,7 +240,9 @@ public void prepareRun(BatchSinkContext context) {
context.getArguments().get(ETLDBOutputFormat.COMMIT_BATCH_SIZE));
}
// set error details provider
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
}
addOutputContext(context);
}
protected void addOutputContext(BatchSinkContext context) {
Expand Down
6 changes: 4 additions & 2 deletions database-commons/src/main/java/io/cdap/plugin/db/source/AbstractDBSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ protected SchemaReader getSchemaReader() {
* @return ErrorDetailsProvider class name
*/
protected String getErrorDetailsProviderClassName() {
return DBErrorDetailsProvider.class.getName();
return null;
}

private DriverCleanup loadPluginClassAndGetDriver(Class<? extends Driver> driverClass)
Expand Down Expand Up @@ -299,7 +299,9 @@ public void prepareRun(BatchSourceContext context) throws Exception {
schema.getFields().stream().map(Schema.Field::getName).collect(Collectors.toList()));
}
// set error details provider
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
if (!Strings.isNullOrEmpty(getErrorDetailsProviderClassName())) {
context.setErrorDetailsProvider(new ErrorDetailsProviderSpec(getErrorDetailsProviderClassName()));
}
context.setInput(Input.of(sourceConfig.getReferenceName(), new SourceInputFormatProvider(
DataDrivenETLDBInputFormat.class, connectionConfigAccessor.getConfiguration())));
}
Expand Down
Loading