[PLUGIN-1845] Return null for ErrorDetailsProvider by default#540
Merged
psainics merged 1 commit intodata-integrations:developfrom Jan 23, 2025
Merged
Conversation
5624109 to
c82b918
Compare
c82b918 to
6de940c
Compare
Contributor
Author
|
Adding a not null check, pipeline fails when setting to setErrorDetailsProvider to null. |
itsankit-google
approved these changes
Jan 23, 2025
Contributor
itsankit-google
left a comment
There was a problem hiding this comment.
Please remember to cherrypick the PRs for release/6.11
This was referenced Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return Null for ErrorDetailsProvider by default to fix DBErrorDetailsProvider export issue
Jira : PLUGIN-1845
Description
Return
nullfor error details provider by default, this is for plugins which have not yet implemented the error details provider.Code change
AbstractDBSource.java