Skip to content

Option to ignore files not in git#23

Open
skazhy wants to merge 1 commit intodakrone:masterfrom
skazhy:test-checked-files
Open

Option to ignore files not in git#23
skazhy wants to merge 1 commit intodakrone:masterfrom
skazhy:test-checked-files

Conversation

@skazhy
Copy link
Copy Markdown

@skazhy skazhy commented Mar 9, 2016

Rationale: I have many "messy" files that are not checked in git (typically living in :profiles :dev :source-paths) & I don't want to lint them until I have checked them in git.

This PR adds a new -c flag that ignores source files that are not tracked by git.

@dakrone
Copy link
Copy Markdown
Owner

dakrone commented May 31, 2016

Hmm.. so the only thing I'm concerned with here is whether this will run into a limit for the command line length, say if there are a lot of files with long names, whether it'll exceed the argument length for the commands.

What do you think about this? It might be better to change it not to expand the full list and instead pass it in a "pipe-y" way?

@skazhy
Copy link
Copy Markdown
Author

skazhy commented May 31, 2016

Totally forgot about this PR, heh.

Recently I found that Python's flake8 provides a neat feature that generates a git hook which only checks staged versions of files in the .git directory & that's is much more elegant solution (no need for a file blacklist; staged files can be linted with gnutools-based checkers pretty fast).

I'll try to see if it works with bikeshed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants