Merged
Conversation
Contributor
Author
|
If this is merged then I can also deal with the complaint for pull request #23 ... it's just a simple filter on the files using http://docs.oracle.com/javase/7/docs/api/java/nio/file/FileSystem.html#getPathMatcher(java.lang.String) |
Owner
|
Thanks for opening this! @DoubleAgent I assume you have a windows machine that this works on? I don't have any windows machines to test on unfortunately |
Contributor
Author
|
I ran against lein-bikeshed on Windows 7 & 10. |
Contributor
Author
|
Hm. Solves Issue #4 |
Owner
|
Merged, thanks @DoubleAgent ! |
immoh
added a commit
to immoh/lein-bikeshed
that referenced
this pull request
Jan 15, 2018
This was accidentally removed in dakrone#31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lein-bikeshed does not run on Windows, but with these small tweaks it does. Bonus: removes the cli dep.