Shibboleth authentication in production - DO NOT MERGE#274
Open
Shibboleth authentication in production - DO NOT MERGE#274
Conversation
Add uid field and index it: uid will now be the primary identifier Add provider field to record which authentication method created a given user Add uid field to User factory
…pment environment Always use database auth in test environment
If a user we haven't seen before logs in via shibboleth create an account for them.
bess
changed the title
no-reply
previously approved these changes
Jan 25, 2018
Collaborator
no-reply
left a comment
no-reply
left a comment
There was a problem hiding this comment.
This looks fabulous. Thank you!
Do you have thoughts about how best to handle creator for importer, in a Shibboleth authenticated world? I'm unsure whether changes will be necessary to that work (merged as #273) when rebasing this.
| RSpec/MultipleExpectations: | ||
| Exclude: | ||
| - 'spec/features/**/*' | ||
| - 'spec/models/user_spec.rb' |
Collaborator
There was a problem hiding this comment.
Is it team opinion that multiple expectations are good (or at least acceptable) across the board? If so, I want to flag this rule for removal in bixby.
Either way, I'm fine with the relevant specs here for now.
Contributor
Author
There was a problem hiding this comment.
I think multiple expectations are fine and even desirable, especially in our context where test setup can be expensive and we want things to run faster. I'd be very happy to see this removed from bixby.
| # methods aren't available. | ||
| def self.use_database_auth? | ||
| return true if Rails.env.test? | ||
| Rails.env.development? && ENV['DATABASE_AUTH'] == 'true' |
no-reply
pushed a commit
that referenced
this pull request
Jan 26, 2018
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
no-reply
pushed a commit
that referenced
this pull request
Jan 26, 2018
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
no-reply
pushed a commit
that referenced
this pull request
Jan 26, 2018
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
no-reply
pushed a commit
that referenced
this pull request
Jan 26, 2018
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With local database authentication in dev environment
I did not squash these PRs because they track the steps I documented here: https://github.com/curationexperts/playbook/blob/shibboleth/authentication/shibboleth_and_hyrax.md
I think it might be handy for future reference to have one PR per documented step. What do you think?
Closes #18
Do not merge this until @mark-dce can weigh in on whether we want to proceed with this before we have access to OHSU Shibboleth systems.