Conversation
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
no-reply
force-pushed
the
import-system-user
branch
2 times, most recently
from
71621a3 to
19a4072
Compare
bess
approved these changes
Jan 28, 2018
Contributor
bess
left a comment
bess
left a comment
There was a problem hiding this comment.
Perfect. This looks like it will work much better post-Shibboleth integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need for a hard coded user with a password, using Hyrax's system user functionality instead. This prefigures Shibboleth support in #274.
Connected to #170.