Skip to content

tools : can reorganize the level tree using folders #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
quentin452 wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

tools : can reorganize the level tree using folders #318

quentin452 wants to merge 25 commits into from

Conversation

@quentin452
Copy link
Contributor

@quentin452 quentin452 commented Mar 23, 2025 •
edited
Loading

todo :

  • fix ctrl + z and probably ctrl + y causing crash if i move an object into a subfolder and click on ctrl + z
  • todo support can drag and drop multiple elements at once easily
  • add drag and drop unit/folder
  • made folders persistant
  • made can rename folder (like unit)
  • refactor code
  • fix creating an unit remove manually created folders
  • replace logic in LevelTreeView.on_database_key_changed() to avoid recreating datas from zero every time
  • todo fix moving a folder to an another folder causing crash
  • todo fix removing an item from subfolder do not refresh view
  • support undo/redo feature
  • support folder drag and drop
  • made can remove folder (like unit)
  • made can dupplicate folder (like unit)

@quentin452 quentin452 marked this pull request as draft March 23, 2025 08:36
@quentin452 quentin452 changed the title tools : add can create basic folder to the tree view tools : can reorganize the level tree using folders Mar 23, 2025
@quentin452
tools: add persistant folder saving , now need to can drag and drop u…
b101279 
…nits/sounds in it
@quentin452
tools: fix many bugs but some bugs during drag and dropping remains
d481051
@quentin452
scripts: fix some nil error from level_editor.lua , step to reproduce…
16efae3 
… here ...

Step to reproduce :

1 : open a .level

2 : drag and drop a folder/unit/sound somewhere

3 : open a new .level (click on save or not the old level)

4 : get the error

14:24:26.245301  editor: lua: ...crown\samples\core\editors\level_editor\level_editor.lua:288: attempt to index a nil value
stack traceback:
	...crown\samples\core\editors\level_editor\level_editor.lua:288: in function <...crown\samples\core\editors\level_editor\level_editor.lua:285>
@quentin452
tools: some bugfixes on on_database_key_changed
d4c50da
@quentin452
tools: many bug and crashes fix to level tree drag and drop implement…
2005391 
…ation
@quentin452
tools: (LevelTreeView) move drag and drop , folder orga , item synchi…
a0cb1a7 
…ng into a dedicated file

+ (regression) fixed if i drag and drop an item into a root folder, he don't make has need to be saved (*)
+ remove unecessary disconnect and connect calls for on_tree_selection_changed
@quentin452
tools: save root folder into .level + simplify a bit the code + do no…
f747c50 
…t trigger set_property if parent_guid != target_guid
@quentin452
tools: do not use hardcoded values in sync_existing_units_and_sounds …
dd6fc47 
…+ optimize sync_items method
@quentin452
tools: avoid hardcoded types usage in on_drag_data_get_internal
c362d9b
@quentin452 quentin452 mentioned this pull request Mar 26, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@quentin452