Adds support for DefaultPrivileges in postgres#199
Merged
Duologic merged 22 commits intocrossplane-contrib:masterfrom Feb 13, 2026
Merged
Adds support for DefaultPrivileges in postgres#199Duologic merged 22 commits intocrossplane-contrib:masterfrom
Duologic merged 22 commits intocrossplane-contrib:masterfrom
Conversation
271b438 to
de33b05
Compare
Contributor
Author
|
Well i manage to get this deployed to kind but it involves
and then it "just works" |
|
Would really love this to be merged as we also need to alter default privs |
2 tasks
|
Hi, will be the PR one day merged? I also need default privileges. |
Contributor
Author
I've started looking into this PR, there's been several changes in the apis used and I'm trying to get a fix in place but will take some time |
fernandezcuesta
added a commit
to fernandezcuesta/provider-sql
that referenced
this pull request
Feb 4, 2026
…+cluster Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
2 tasks
fernandezcuesta
added a commit
to fernandezcuesta/provider-sql
that referenced
this pull request
Feb 10, 2026
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
added a commit
to fernandezcuesta/provider-sql
that referenced
this pull request
Feb 10, 2026
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
2 tasks
…oller Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
…ources we can add default privileges Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
2 tasks
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fix: adapt for v2, fix default privileges and add examples and tests
8ea7a85 to
97e9014
Compare
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
Duologic
approved these changes
Feb 13, 2026
Member
Duologic
left a comment
There was a problem hiding this comment.
I've scanned through the code, didn't see anything obviously wrong. I don't know too much about Postgres/DefaultPrivileges myself to deeply verify that this is correct. I'm happy to merge it when CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support to DefaultPrivileges for postgres.
Fixes #117
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I've been trying to test this locally but i'm really struggling to deploy the provider to a local kind clusterIt's following the same pattern as the grants, we only care about the creation of the default privileges as the grant/revoke runs in a single transaction.
From xocasdashdash#1 by @fernandezcuesta
Locally with a kind cluster, running from the
examplesfolder and verified with: