Adds support for DefaultPrivileges in postgres (Encore)#313
Draft
xocasdashdash wants to merge 20 commits intocrossplane-contrib:masterfrom
Draft
Adds support for DefaultPrivileges in postgres (Encore)#313xocasdashdash wants to merge 20 commits intocrossplane-contrib:masterfrom
xocasdashdash wants to merge 20 commits intocrossplane-contrib:masterfrom
Conversation
…oller Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
…ources we can add default privileges Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Signed-off-by: Joaquín Fernández Campo <xocasdashdash@users.noreply.github.com>
Merged
2 tasks
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fix: adapt for v2, fix default privileges and add examples and tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds support to DefaultPrivileges for postgres. This is a new PR that is just rebased #199 to facilitate #312
Fixes #117
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I've been trying to test this locally but i'm really struggling to deploy the provider to a local kind cluster.
It's following the same pattern as the grants, we only care about the creation of the default privileges as the grant/revoke runs in a single transaction.