refactor: Move code from main into sub packages#62
Open
MisterMX wants to merge 1 commit intocrossplane-contrib:mainfrom
Open
refactor: Move code from main into sub packages#62MisterMX wants to merge 1 commit intocrossplane-contrib:mainfrom
MisterMX wants to merge 1 commit intocrossplane-contrib:mainfrom
Conversation
2 tasks
MisterMX
force-pushed
the
refactor/pkg-fn
branch
from
2686d47 to
8fbe784
Compare
Contributor
Author
|
Rebased on b1998a7 and added some defaults to |
Move internal logic into `internal/fn` and expose constructor in `pkg/fn` that can be importet in other modules. Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
refactor/pkg-fn
branch
from
8fbe784 to
f72823f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Move internal logic into
internal/fnand expose constructor inpkg/fnthat can be imported in other modules.Similar to crossplane-contrib/function-patch-and-transform#76.
I have: