refactor: Use fs.FS interface instead of os file access#63
Merged
phisco merged 1 commit intocrossplane-contrib:mainfrom Jan 24, 2024
Merged
refactor: Use fs.FS interface instead of os file access#63phisco merged 1 commit intocrossplane-contrib:mainfrom
fs.FS interface instead of os file access#63phisco merged 1 commit intocrossplane-contrib:mainfrom
Conversation
MisterMX
changed the title
os file accessfs.FS interface instead of os file access
MisterMX
force-pushed
the
refactor/fs-interface
branch
from
f224b58 to
070c8cb
Compare
Replace all IO operations based on the `os` package with the ones from the abstract `fs` package and pass a `fsys` parameter down to functions that need it. Use a custom `osFS` in main() that just wrap around `os.Open`. Use `embed.FS` in tests. Signed-off-by: Maximilian Blatt <maximilian.blatt-extern@deutschebahn.com>
MisterMX
force-pushed
the
refactor/fs-interface
branch
2 times, most recently
from
5482acb to
1e44f6c
Compare
Contributor
Author
|
Updated this PR and removed the dependency on #62. |
MisterMX
force-pushed
the
refactor/fs-interface
branch
from
1e44f6c to
a3a0cca
Compare
phisco
reviewed
Jan 24, 2024
phisco
approved these changes
Jan 24, 2024
MisterMX
force-pushed
the
refactor/fs-interface
branch
3 times, most recently
from
21e7fb2 to
966acd6
Compare
ezgidemirel
approved these changes
Jan 24, 2024
Collaborator
ezgidemirel
left a comment
ezgidemirel
left a comment
There was a problem hiding this comment.
Thanks @MisterMX, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Replace all IO operations based on the
ospackage with the ones from the abstractfspackage and pass afsysparameter down to functions that need it.Use
embed.FSin tests.Depends on #62I have: