Conversation
I think [dependency-groups] is preferred for uv. And this changes the `sync` commands since the dev group is synced by default, so no need for an extra flag.
4b0f345 to
c455edd
Compare
It got deleted somehow
fix circular import: evals/__init__ → evals/gcg/gcg → attacks/__init__ → attacks/embedding_attack → attacks/base → evals/__init__ the fix is to move the gcg implementation from attacks/ to evals/
Collaborator
Author
|
This probably deserves review but I'm going to merge to avoid adding to the backlog of PR review, and to get CircleCI passing |
This was referenced Feb 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
infra:
main, runs multi-GPU tests through Runpod.tests:
expensiveand doesn't run them in CI because they're too expensive for smoke teststest_lora_finetune_cheap(uses pythia-14m)fixes:
attacks/toevals/Testing
CircleCI passes, including multi-GPU tests