Skip to content

GCG: fix circular import#83

Closed
tomtseng wants to merge 1 commit intomainfrom
tomtseng/gcg-circular
Closed

GCG: fix circular import#83
tomtseng wants to merge 1 commit intomainfrom
tomtseng/gcg-circular

Conversation

@tomtseng
Copy link
Collaborator

@tomtseng tomtseng commented Feb 7, 2026

fix circular import: evals/init → evals/gcg/gcg → attacks/init → attacks/embedding_attack → attacks/base → evals/init

the fix is to move the gcg implementation from attacks/ to evals/

fix circular import: evals/__init__ → evals/gcg/gcg → attacks/__init__ → attacks/embedding_attack → attacks/base → evals/__init__

the fix is to move the gcg implementation from attacks/ to evals/
@tomtseng
Copy link
Collaborator Author

tomtseng commented Feb 7, 2026

I cherry-picked this into #69 and forgot to rebase it out before merging #69, so I'll just close this

@tomtseng tomtseng closed this Feb 7, 2026
@tomtseng tomtseng deleted the tomtseng/gcg-circular branch February 10, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant