Modernize sandbox: Reduce footprint of Buildout, fix macOS >= 11, improve CI #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
amotl
changed the title
This was referenced Jun 20, 2022
matriv
reviewed
Jun 20, 2022
|
|
||
| [tox] | ||
| recipe = gp.recipe.tox | ||
| [crate:macosx] |
Contributor
There was a problem hiding this comment.
Should we consider (it's a more generic question, about our builds, etc.) the new Apple (M1 and soon M2) chips?
Member
Author
There was a problem hiding this comment.
Thank you. I've added a note about that topic at https://github.com/orgs/crate/projects/20#card-83361325.
Member
There was a problem hiding this comment.
Our own code is pure python and not platform dependent. I don't think we need to go overboard with the test matrix.
If GHA action happens to add runners, sure why not, but please don't put other extra effort into this.
Member
Author
There was a problem hiding this comment.
I agree and deleted the note again. The state of support for M1 Silicon on GHA is tracked over here:
- The sandbox setup is now based on vanilla Python and virtualenv. - A convenient bootstrap script is provided, which can be used like `source bootstrap.sh`. - The test runner has not been changed, it is still `zope.testrunner`. - The command line invocation interface `./bin/test` has not been changed. - Buildout is now only used for downloading the CrateDB tarball using `hexagonit.recipe.download`. References: - #428 - crate-workbench/test-buildout-python310#1
Instead of using GNU getopt in the `setup_ci.sh` program, the needed information is propagated using environment variables.
amotl
force-pushed
the
amo/reduce-buildout
branch
from
bbb9beb to
13a494b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
the Buildout-based sandbox croaked on some ends. It has been investigated on behalf of #428 and crate-workbench/test-buildout-python310#1, and finally converged into an upstream bug report at buildout/buildout#609.
However, I am at the same time taking the chance to reduce the footprint of the Buildout setup on
crate-pythonto resolve and improve the situation.source bootstrap.sh, both locally and on CI.zope.testrunner../bin/testhas not been changed.hexagonit.recipe.downloadrecipe.BUILDOUT_VERSION,CRATEDB_VERSIONandSQLALCHEMY_VERSIONhave been introduced for defining the corresponding software component versions. Those will be used for propagating information from the build matrix slot. With this change, we can get rid of needing GNU getopt in thesetup_ci.shprogram, which further reduces the amount of specialized routines needed to satisfy specific platform requirements.With kind regards,
Andreas.