Skip to content

fix: replace the search dialog to avoid a client-side exception #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecuvii wants to merge 10 commits into
base: master
Choose a base branch
from
+13 −19
Open

fix: replace the search dialog to avoid a client-side exception #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
77513bf
refactor: enhance static parameter generation and improve heading com…
thecuvii Jan 22, 2026
f8adc2c
refactor: update development server port and enhance search dialog in…
thecuvii Jan 22, 2026
cd92624
refactor: enforce static rendering for dynamic pages
thecuvii Jan 22, 2026
8dbf156
refactor: clean up imports in layout and page components
thecuvii Jan 22, 2026
fd97189
refactor: simplify development server command in package.json
thecuvii Jan 22, 2026
77a6d79
refactor: streamline static parameter generation and update developme…
thecuvii Jan 22, 2026
e0be5e0
refactor: enhance static parameter generation in page.tsx
thecuvii Jan 22, 2026
6876a20
refactor: simplify Heading component rendering logic
thecuvii Jan 22, 2026
0347f62
refactor: update development server command in package.json
thecuvii Jan 22, 2026
d61cb9a
refactor: simplify SidebarItem component by removing prefetch prop
thecuvii Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 5 additions & 11 deletions src/app/[[...slug]]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,11 @@ export default async function Page(props: PageProps<"/[[...slug]]">) {
);
}

export async function generateStaticParams() {
const params = source.generateParams();

// Ensure we include the root path for optional catch-all routes
const hasRootPath = params.some((p) => !p.slug || p.slug.length === 0);

if (!hasRootPath) {
return [{ slug: undefined }, ...params];
}

return params;
export function generateStaticParams() {
return [
{ slug: [] }, // Handle root path
...source.generateParams()
]
}

export async function generateMetadata(
Expand Down
3 changes: 2 additions & 1 deletion src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Inter } from "next/font/google";
import { cn } from "@/lib/cn";
import { source } from "@/lib/source";
import { DocsLayout } from "@/components/layout/docs";
import { DefaultSearchDialog } from "@/components/search";

const inter = Inter({
subsets: ["latin"],
Expand Down Expand Up @@ -75,7 +76,7 @@ export default function Layout({ children }: LayoutProps<"/">) {
/>
</head>
<body className={cn("flex flex-col min-h-screen", inter.className)}>
<RootProvider theme={{ enabled: false }}>
<RootProvider theme={{ enabled: false }} search={{SearchDialog:DefaultSearchDialog}}>
<DocsLayout tree={source.pageTree}>
{children}
</DocsLayout>
Expand Down
7 changes: 3 additions & 4 deletions src/components/layout/sidebar/base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,14 +269,13 @@ export function SidebarItem({
}) {
const pathname = usePathname();
const ref = useRef<HTMLAnchorElement>(null);
const { prefetch } = useSidebar();
const active =
props.href !== undefined && isActive(props.href, pathname, false);

props.href !== undefined && isActive(props.href, pathname, false);
useAutoScroll(active, ref);

return (
<Link ref={ref} data-active={active} prefetch={prefetch} {...props}>
<Link ref={ref} data-active={active} {...props}>
{icon ?? (props.external ? <ExternalLink /> : null)}
{children}
</Link>
Expand Down
6 changes: 3 additions & 3 deletions src/components/search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function initOrama() {
});
}

export default function DefaultSearchDialog(props: SharedProps) {
export function DefaultSearchDialog(props: SharedProps) {
const { locale } = useI18n(); // (optional) for i18n
const { search, setSearch, query } = useDocsSearch({
type: 'static',
Expand All @@ -40,8 +40,8 @@ export default function DefaultSearchDialog(props: SharedProps) {
<SearchDialogInput />
<SearchDialogClose />
</SearchDialogHeader>
<SearchDialogList items={query.data !== 'empty' ? query.data : null} />
<SearchDialogList items={query?.data !== 'empty' ? query.data : null} />
</SearchDialogContent>
</SearchDialog>
);
}
}